Test: Replace t.error/fatal with assert/request in [raft_paper_test.go] #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pav-kv
approved these changes
Mar 11, 2024
| assert.Equal(t, uint64(2), r.Term) | ||
| assert.Equal(t, StateCandidate, r.state) | ||
| assert.True(t, r.trk.Votes[r.id]) | ||
|
|
||
| msgs := r.readMessages() | ||
| sort.Sort(messageSlice(msgs)) |
There was a problem hiding this comment.
For another PR: consider removing messageSlice, and using slices.SortFunc with some stable comparator.
There was a problem hiding this comment.
Would this be what you had in mind?
slices.SortStableFunc(data, orderMessageAsc)
func sortMessageAsc(a pb.Message, b pb.Message) int {
strA := fmt.Sprint(a)
strB := fmt.Sprint(b)
if strA > strB {
return 1
} else if strA < strB {
return -1
} else {
return 0
}
}
Signed-off-by: Xinyuan Du <[email protected]>
MrDXY
force-pushed
the
replace-test-errors-with-assert-(raft_paper_test.go)
branch
from
34fe5ef to
7f0764c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: Replacing t.Error/t.Fatal with assert/require
This commit tries to eliminate boilerplate code in the testing suite by replacing occurrences
of t.Error and t.Fatal with assertions from the assert and require packages.
Changes Made:
Affected Files:
Part of: #146